Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix image layer visibility toggle via glue-jupyter #2595

Merged
merged 1 commit into from
Dec 7, 2023
Merged

fix image layer visibility toggle via glue-jupyter #2595

merged 1 commit into from
Dec 7, 2023
+9 −14

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Dec 7, 2023 •
edited
Loading

Description

This pull request fixes the image layer visibility toggle in plot options by bumping glue-jupyter (glue-viz/glue-jupyter#412), which in turn requires a bump to glue-core, which also removes the need for backwards-compatibility code introduced in #2591 (and future-proofs by calling stretch_object instead of instantiating on the fly within the stretch histogram code).

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added bug Something isn't working 💤backport-v3.8.x on-merge: backport to v3.8.x labels Dec 7, 2023
@kecnry kecnry added this to the 3.8.1 milestone Dec 7, 2023
@kecnry
bump glue-jupyter
d00020c 
which in turn requires a bump to glue-core
@kecnry kecnry marked this pull request as ready for review December 7, 2023 14:03
@codecov Codecov
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a86e698) 91.53% compared to head (d00020c) 91.51%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2595      +/-   ##
==========================================
- Coverage   91.53%   91.51%   -0.02%     
==========================================
  Files         161      161              
  Lines       19602    19596       -6     
==========================================
- Hits        17942    17934       -8     
- Misses       1660     1662       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry changed the title bump glue-jupyter fix image layer visibility toggle via glue-jupyter Dec 7, 2023
haticekaratay
haticekaratay approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@haticekaratay haticekaratay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

pllim
pllim approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim pllim merged commit bd312bd into spacetelescope:main Dec 7, 2023
17 of 19 checks passed
@lumberbot-app Lumberbot (App)
Copy link

lumberbot-app bot commented Dec 7, 2023

Something went wrong ... Please have a look at my logs.

It seems that the branch you are trying to backport to does not exist.

@pllim
Copy link
Contributor

pllim commented Dec 7, 2023

Weird.

@meeseeksdev backport to v3.8.x

meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Dec 7, 2023
@pllim @meeseeksmachine
Backport PR spacetelescope#2595: fix image layer visibility toggle vi…
e99d69f 
…a glue-jupyter
@meeseeksmachine meeseeksmachine mentioned this pull request Dec 7, 2023
Merged
pllim added a commit that referenced this pull request Dec 7, 2023
@pllim
Merge pull request #2596 from meeseeksmachine/auto-backport-of-pr-259…
8201c79 
…5-on-v3.8.x

Backport PR #2595 on branch v3.8.x (fix image layer visibility toggle via glue-jupyter)
@kecnry kecnry deleted the image-vis-fix branch December 7, 2023 14:37
@pllim pllim mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haticekaratay haticekaratay haticekaratay approved these changes

@pllim pllim pllim approved these changes

@rosteen rosteen Awaiting requested review from rosteen rosteen is a code owner

@javerbukh javerbukh Awaiting requested review from javerbukh javerbukh is a code owner

@bmorris3 bmorris3 Awaiting requested review from bmorris3 bmorris3 is a code owner

@cshanahan1 cshanahan1 Awaiting requested review from cshanahan1 cshanahan1 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working Ready for final review 💤backport-v3.8.x on-merge: backport to v3.8.x
Projects
None yet
Milestone
3.8.1
Development

Successfully merging this pull request may close these issues.
3 participants
@kecnry @pllim @haticekaratay